Demo RevMax Plugin for OpenX

Questions about openx adserver plugin RevMax?

RevMax OpenX Plugin Features

Author Topic: Sorting of Ad Packages  (Read 795 times)

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Sorting of Ad Packages
« on: May 16, 2011, 07:20:01 AM »
One thing that I've noticed, and would like to see changed, is the sorting of the ad packages when presented to the advertiser.

At present, they're sorted in the order which they were added.  This looks like a mess and I'd like to see them sorted by packages name in ascending order.

I'd simply add 'ORDER BY' within the pkg_select function, but the file's encoded.  Could you either change the default sort order or enable the specification of one as a configurable?

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #1 on: May 16, 2011, 07:35:09 AM »
Good point.
I had actually made some other changes that have not been added yet also,
so perhaps I can get this done tomorrow and get it out to you all.

Shoot me a reminder email on the contact link tomorrow if I forget / get busy.
Mike

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #2 on: May 17, 2011, 02:59:18 AM »
I have added filtering to RevMax-packages.php and
enforced security on client banner uploads.

more info and instructions can be found here.
http://btdsoft.com/revmax-updated-4-0-3-pr2/

Let me know if you need help.
Mike

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #3 on: May 17, 2011, 03:09:25 AM »
Thanks for that.  However, I tried to download the new version via the download link as instructed at http://btdsoft.com/revmax-updated-4-0-3-pr2, but am getting the previous version (4.0.3-pr1) still.  How do I download 4.0.3-pr2?

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #4 on: May 17, 2011, 04:32:47 AM »
Thanks for that.  However, I tried to download the new version via the download link as instructed at http://btdsoft.com/revmax-updated-4-0-3-pr2, but am getting the previous version (4.0.3-pr1) still.  How do I download 4.0.3-pr2?

If you are talking about what it shows in your admin screen, its correct. I did not take the time to update that but will now so people dont get confused.

I will look again, I am pretty sure its the right one, did you check the dates on the two files in question ?

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #5 on: May 17, 2011, 04:41:56 AM »
If you are talking about what it shows in your admin screen, its correct. I did not take the time to update that but will now so people dont get confused.

I will look again, I am pretty sure its the right one, did you check the dates on the two files in question ?
Yes, I just had a look at the dates of the archives inside the main archive and see a difference for the "RevMax.zip" file.  I was going by the version that I saw in the ReadMe file.

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #6 on: May 17, 2011, 05:00:02 AM »
One last question, I do not see where the packages are sorted; where you able to get that into this release?  I see the search options within the Admin area, but they are still displayed in the order which they were created in other areas such as the signup page.  As I can't edit the ecnoded functions, could you possibly provide a file with the packages sorted alphabetically by name in ascending order?  I think that would look somewhat cleaner to the advertisers ordering the package(s) and would also allow them to find them more easily.

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #7 on: May 17, 2011, 05:02:55 AM »
One last question, I do not see where the packages are sorted; where you able to get that into this release?  I see the search options within the Admin area, but they are still displayed in the order which they were created in other areas such as the signup page.  As I can't edit the ecnoded functions, could you possibly provide a file with the packages sorted alphabetically by name in ascending order?  I think that would look somewhat cleaner to the advertisers ordering the package(s) and would also allow them to find them more easily.
The new search feature in packages admin = order by the field you want.

If you are talking about outside in the clients signup area
that is all unencrypted and expected you would do as you want.

I have updated the number within package and the read me now.
Thanks for pointing that out.
Mike

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #8 on: May 17, 2011, 05:15:37 AM »
If you are talking about outside in the clients signup area
that is all unencrypted and expected you would do as you want.

Yes, specifically, I'm referring to the sign-up page.  Are the packages not pulled using the pkg_select function?  I suppose I could replace that function with my own to pull the information from the database, but it would be better to just make that the default sort order wouldn't it?

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #9 on: May 17, 2011, 05:24:06 AM »
Yes, specifically, I'm referring to the sign-up page.  Are the packages not pulled using the pkg_select function?  I suppose I could replace that function with my own to pull the information from the database, but it would be better to just make that the default sort order wouldn't it?

Ok, perhaps we are now on the same page.
So on the signup page you would like to sort packages by what exactly ?

You can use the make public function allready, in admin.
You can use the custom url feature and show a singular package on the page.

In this way you can limit to 1 or as many as you would like public.
How do you feel it could be better done or more suitable for your needs ?
Let me know.
Mike

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #10 on: May 17, 2011, 05:31:09 AM »
Ok, perhaps we are now on the same page.
So on the signup page you would like to sort packages by what exactly ?

You can use the make public function allready, in admin.
You can use the custom url feature and show a singular package on the page.

In this way you can limit to 1 or as many as you would like public.
How do you feel it could be better done or more suitable for your needs ?
Let me know.
Mike
Currently, we have 15 separate ad packages; for example.  As such, it is a mess for a potential advertiser to view the rates and/or find their individual package.  I would like for the packages to be sorted by package name in ascending alphabetic order.

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #11 on: May 17, 2011, 05:33:59 AM »
Either that or you could simply ad another configurable option to the ad packages where a sort order can be defined and then they would display in whatever order is specified by the configured sort order.  The last option would allow greater flexibility for everybody though as they could just specify a digit for the desired sort order in the admin area.  But, I think, at least, the default wold be better as alphabetic sorting by package name as opposed to simply the order they were inserted to the database.

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #12 on: May 17, 2011, 05:57:40 AM »
Either that or you could simply ad another configurable option to the ad packages where a sort order can be defined and then they would display in whatever order is specified by the configured sort order.  The last option would allow greater flexibility for everybody though as they could just specify a digit for the desired sort order in the admin area.  But, I think, at least, the default wold be better as alphabetic sorting by package name as opposed to simply the order they were inserted to the database.

Unclear, cant you do a sort on the returned results in advertisers.php ?
http://www.php.net/manual/en/function.sort.php

Offline YourWebHostReviews

  • Newbie
  • *
  • Posts: 8
    • YourWebHostReviews.net
Re: Sorting of Ad Packages
« Reply #13 on: May 17, 2011, 06:00:33 AM »
For now, I simply replaced the function call with my own query to the database to pull the packages in the order that I want.  However, you may want to consider my suggestions for a future release though; namely, the addition of a sort order configurable.  it would only involve the addition of a single column (i.e. 'sort') to the 'RM_packages' table.  Administrators could then define a sort order within the package when it's created, allowing the packages to be sorted in whatever order they want every in the system that the packages are displayed.

Offline btdsoft

  • Administrator
  • Full Member
  • *****
  • Posts: 124
  • btdsoft.com Independant OpenX Consultant
    • btdsoft.com
Re: Sorting of Ad Packages
« Reply #14 on: May 17, 2011, 08:05:04 AM »
For now, I simply replaced the function call with my own query to the database to pull the packages in the order that I want.  However, you may want to consider my suggestions for a future release though; namely, the addition of a sort order configurable.  it would only involve the addition of a single column (i.e. 'sort') to the 'RM_packages' table.  Administrators could then define a sort order within the package when it's created, allowing the packages to be sorted in whatever order they want every in the system that the packages are displayed.

Sounds good.
Wish I had of understood you this morning, it would have been done.
Perhaps tomorrow.
Mike